Ensure layout classnames are applied to the inner blocks wrapper#11598
Ensure layout classnames are applied to the inner blocks wrapper#11598tellthemachines wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Very tiny nit, but should we add the trac ticket number to the test_layout_support_flag_renders_classnames_on_wrapper test, since the data provider now has a new entry?
tellthemachines
force-pushed
the
fix/layout-class-wrapper
branch
from
6b684b7 to
225d391
Compare
There was a problem hiding this comment.
This looks good to me! It correctly syncs the Gutenberg PR (WordPress/gutenberg#77408) and is a good iterative improvement over trunk (skip void elements and tags with a closer).
While in the linked PR there was a suggestion to investigate using WP_HTML_Processor (instead of WP_HTML_Tag_Processor), the explorations into doing so proved worse in terms of performance than this approach, so this seems like the right one to get in to me.
Also, if there's a desire to revisit the approach, there's still plenty of time to come back to it in the 7.1 cycle. So LGTM to land 🚀
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/65101
Syncs WordPress/gutenberg#77408.
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.